Shinigami

Results 796 comments of Shinigami

It's working? omg that would be really nice, thank you @mshima for this fix, I assume you will make many happy with that

> I think this is because of: > > https://github.com/faker-js/faker/blob/56424709b7ccd7aa7fe6130c78a770a0a901d7b5/package.json#L36 > > This makes node esm to import cjs version. Should be `require` instead of `node`. I was not fully...

I will test this again this evening, due to I do not have the local playground on my workstation laptop but on my home pc

cjs js: ```node Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './locales/es' is not defined by "exports" in /home/shinigami/OpenSource/faker.js-tests/cjs/node_modules/@faker-js/faker/package.json ``` cjs ts: ```node Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './locales/es' is not defined by "exports" in...

@mshima I created a playground here: https://github.com/faker-js/playground Feel free to ask if something is unclear

@mshima are you still interested in this PR? Or should someone take it over?

@mshima I see this PR and I like it, but currently our maintainer resources are a bit limited and we have a bunch of other things on our agenda. So...

IMO this is not really a good idea eslint and prettier will get in conflict with that and setting it to a certain limit length is also not helpful depending...

Closes because, see reasons above.

I like the idea, but I wont name it `normal` and `reversed` as this is just "our" "western" normal, but in asian countries the "normal" is our "reversed" :thinking: