Shinigami

Results 800 comments of Shinigami

@xDivisionByZerox did you progress on a PR for checking alphabetically sorted locales? I think we should test it and add a manual filtering step to define if we want to...

Attention: `faker.name.gender()` is not designed to be used as an input value for `gender`-parameter. `faker.name.gender()` can return any kind of string and also will not return `Male` or `Female` for...

Also some good point. I would like to raise the concern that I understand that it could be useful to add in the name module, but doesn't make much sense...

I just found out that it is possible to execute the following code: ```ts import { Gender } from '@faker-js/faker' const genders = Object.values(Gender); const randomGender = faker.random.objectElement(Gender); faker.name.firstName(genders[0]); //...

We could also provide `export const GENDER_TYPES: readonly GenderType[]` as a helper for iterating over all possible input parameters.

We had a HUGE internal and long conversation and we may want to switch `GenderType` to be `'femme' | 'masc' | 'non-gendered'` or something similar. This would have the advantage...

> IDK, `crypto()` could fit into the `finance` module and `hashAlorythm()` in the `hacker` module. I don't see the need for a new module. That is exactly my same thought...

> Yeah, should I change this issue to "implement finance.crypto() and hacker.hashAlgorithm()"? Should I make another issue? Should those two functions be in separate issues? Yeah, maybe even better `finance.blockchainCrypto()`...

I somehow like this idea 🤔 it would also improve `finance.amount`, as now it's somewhat just a wrapper around `datatype.number` + a currency symbol. But this would also need good...

Oh I thought we just replace the implementation of `finance.amount` and change its behaviour 🤔