Shinigami

Results 779 comments of Shinigami

Okay, I think I need to generate at build-time a data json for the search page, because I would like to prevent the need of recreating the search data object...

Current State ![image](https://user-images.githubusercontent.com/7195563/185901074-b75de0f0-ea18-460e-a087-6f68f4313c7f.png) Anything else to get that merged? Or could we maybe enhance it in later PRs if needed and serve now the doc-user UX?

My assumption currently is that we moved away a bit from what `standard-version` expect https://github.com/faker-js/faker/blob/e1905064091acc9e56a895bc2555803fc97bb08c/package.json#L80 So this package might only know `feat` and `fix` and ignores things like `chore` and...

I currently not have the time to look into it to deep but one of my first questions would be if `standard-version` is still needed or if this also create...

We will move this into number module, but this would just come in v8 Because this might not be that far away, we don't want to introduce a planned deprecation...

This looks ridiculously easy :thinking: _sus_?

> Does the `npm publish` automatically include a build? Yes it does, since 6.1.1 https://github.com/faker-js/faker/commit/62dcfc9658e6d3ee23b9e674d10b9a229b026d0e#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R76 But this PR would not change something for that, cause it now would do it...

@xDivisionByZerox yes, for me that sounds more safe 1. PR for sort 2. PR for dedup That way we have a better commit history in main branch

This needs to be done together with e.g. #642, because with out that, it's nearly impossible to build own `Faker` instances.

> I like `helpers` more than `helper`. If you want to use singular names everywhere, then maybe use `util`? (It is as generic as `helpers`) I had the exact same...