Sherwin Varghese
Sherwin Varghese
> @Sherwin-14, is this PR still relevant? I think it is. I think this stalled for a reason that I am not able to recall at the moment, @mfisher87 might...
> @Sherwin-14, please merge main into your branch and resolve conflicts, and then we can review it. This PR needs to be rewritten imho, because of the amount of conflicts...
Hey, Could you assign me this one? I have started to work on this and I had some doubts. First of all, I have updated all the tests having `assertions.assertTrue(x)`...
> This test file is a good example: https://github.com/nsidc/earthaccess/blob/main/tests/integration/test_onprem_download.py#L51-L63 Looks like most of the integration test files have this problem, but not all (e.g. `test_auth.py` looks OK). Yeah but I...
Oh there seems to be some misunderstanding here! I was talking about the `granules` function in `test_kerchunk.py` that is fixturized at the moment. So I was basically asking for one...
Not yet 😅. I just need an example of the setup function that is not fixturized yet.
The `auth` and `store` objects can be considered as setup's, is that what you are implying? Also I think that the `conftest.py` file should contain all the fixturized functions. So...
Hey, In that case may be grouping them into a function and then fixturizing it can be a solution isn't it? or Am I missing something?
Thanks for the feedback, Marc! The CI tests seem to be failing though and I can't figure it out why, any clues?
> * df_pd_1 Hey, needed some clarification over this. I have changed both the data's to `data_1` and `data_2` but I am confused as to how we can change df...