earthaccess icon indicating copy to clipboard operation
earthaccess copied to clipboard

Refactor integration test "arrange" step for auth objects

Open Sherwin-14 opened this issue 1 year ago • 6 comments

I've added the fixtures but it seems like a lot more errors are pop up.


📚 Documentation preview 📚: https://earthaccess--752.org.readthedocs.build/en/752/

Sherwin-14 avatar Jul 08 '24 09:07 Sherwin-14

Converted to draft until we can figure out new errors

mfisher87 avatar Jul 08 '24 16:07 mfisher87

ERROR tests/integration/test_cloud_download.py::test_earthaccess_can_download_cloud_collection_granules[daac0] - assert False is True
 +  where False = <earthaccess.auth.Auth object at 0x7f878cba0310>.authenticated

Looks like our session isn't authenticated as expected. Perhaps we could debug tomorrow during the hack day? I know that's not a very accessible time of day in your timezone, so if you aren't able to make it, I'll plan on spending that time investigating and share back here :)

mfisher87 avatar Jul 08 '24 17:07 mfisher87

@Sherwin-14, is this PR still relevant?

chuckwondo avatar Jun 26 '25 15:06 chuckwondo

@Sherwin-14, is this PR still relevant?

I think it is. I think this stalled for a reason that I am not able to recall at the moment, @mfisher87 might have more context about this.

Sherwin-14 avatar Jun 26 '25 15:06 Sherwin-14

@Sherwin-14, please merge main into your branch and resolve conflicts, and then we can review it.

chuckwondo avatar Jun 26 '25 18:06 chuckwondo

@Sherwin-14, please merge main into your branch and resolve conflicts, and then we can review it.

This PR needs to be rewritten imho, because of the amount of conflicts that have been accumulated. I don't feel like I will be able to resolve all of that for now, so I guess we can work on this PR later. Once I get a hang of the context, then I can rewrite this PR again using PR diff as a guide.

Sherwin-14 avatar Jun 27 '25 14:06 Sherwin-14