Sherwin Varghese

Results 83 comments of Sherwin Varghese

I will try to come up with a PR that follows the rubric. I think if we are able to encompass all the rules of the rubric in one single...

> That sounds great! Thanks for being willing to dive deep on this! ❤️ @mfisher87 Can we use the PR for backwards compatibility as an Ideal PR?

I feel my PR has proper methodology, what I mean by that is that you will have to make changes to CHANGELOG before making a PR which I guess is...

@mfisher87 This seems interesting, what should we proceed `immediate`or `deferred`?

```py def get( self, granules: Union[List[DataGranule], List[str]], local_path: Union[Path, str, None] = None, provider: Optional[str] = None, threads: int = 8, ) -> List[str]: if local_path is None: today =...

@mfisher87 Hey I think this is similar to the one we just did. Any specific opinions on this?

> @Sherwin-14, do you have enough information to proceed with the changes I requested? Yeah I have the info I needed, I had put this on hold since I was...

> We decided during hack day today that we want to allow users to customize pqdm behaviors like so: > > ```python > def open(something, threads=16, *, pqdm_kwargs={...}, ...): >...

> @Sherwin-14, do you need some help with this? I will try to accomodate the change asap, I was caught up in something else up untill now

@chuckwondo ``` python def download( granules: Union[DataGranule, List[DataGranule], str, List[str]], local_path: Optional[str], provider: Optional[str] = None, threads: int = 8, pqdm_kwargs: dict = {} ) -> List[str]: """Retrieves data granules...