Chow

Results 16 comments of Chow

No objections. Current new id process is based on previous one. It is better to create a new struct containing two seperate variables and using interface rather than idshift as...

if (parseContext.relaxedErrors()) parseContext.ppWarn(ppToken->loc, "nonportable when expanded from macros for preprocessor expression", "defined", ""); Try to add relaxederror option for PP to only warn here.

Re-create to check expired build log.

> In addition, this PR generates invalid SPIR-V for some inputs. For example, running `dxc -T ps_6_1 -E main foo.hlsl -spirv` on > > ```hlsl > enum VertexID { >...

> Thanks for reminding. I'll make a commit recently to fix issue discussed above.

Dependency PR: https://github.com/KhronosGroup/glslang/pull/3074

Update: may pending for a which as introducing new legacy check functions here, leading to too many test results changes, would double check.

> Any updates on this? Missing this feature :) I'm waiting for review now. You can have a try with this PR, main features should have been finished.

Fixed conflict in spvEmitter. Add comment to SV_BaryCentrics builtin cases in CapatibilityVisitor.

@cassiebeckley Hi cassie, I've resolved conflicts, any further changes I need to make for this PR?