Shashi Bhushan comments

Results 6 comments of


                                            Shashi Bhushan

Filter trying to write invalid characters

Hi @jbornemann I've tried rewriting the name in ProtoNodeDecorator#getOrCreateNode(Session) method, using https://jackrabbit.apache.org/api/1.4/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String), as well as with https://docs.adobe.com/content/docs/en/cq/5-6-1/javadoc/com/day/cq/commons/jcr/JcrUtil.html#createValidName(java.lang.String) One issue i found with Text#escapeIllegalJcrChars is it will escape colon(:) as well,...

Filter trying to write invalid characters

@jdigger, @sagarsane what's your take on this one ?

Add an ability to give order the paths in Grabbit Configs

Had a discussion with @jbornemann regarding this, quoting him from the discussion > Any solution will be too complicated compared to the value it would give us. At the very...

SLICE-128 making SliceLookUpTag type attribute value String

[Slice-128](https://cognifide.atlassian.net/browse/SLICE-128) - [x] made type attribute in slice:lookup tag of String type

SLICE-128 making SliceLookUpTag type attribute value String

@mmajchrzak Added a new Util method SliceTagUtils#getFromCurrentPath(PageContext, String, String), Also commented out the Failing Test case for now. Will include it after a final implementation of the method in SliceTagUtils.

SLICE-128 making SliceLookUpTag type attribute value String

@mmajchrzak I've updated SliceLookupTag.java. The setter can be now be used for String as well, but as you specified because major version has been incremented, this will probably go into...