Slice
Slice copied to clipboard
wttech
SLICE-128 making SliceLookUpTag type attribute value String
Coverage decreased (-0.4%) to 71.32% when pulling 48f58b47cfe77f3a42043b59a95aefa1233a40af on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
Coverage decreased (-0.4%) to 71.32% when pulling ee07da0152bb807d9f0a626a407eed495dc73ad5 on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
- [x] made type attribute in slice:lookup tag of String type
Coverage decreased (-0.4%) to 71.32% when pulling 314679a2e006e22722c2ead62783d6205f9ceec2 on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
Coverage decreased (-0.3%) to 71.365% when pulling 4b910c0eadda11428acbf05bc7ab69d765d2d932 on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
Coverage increased (+0.1%) to 71.81% when pulling 46e22c6af7710d195e08b89acdbb65b95416b6d0 on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
Coverage increased (+0.1%) to 71.81% when pulling 572e3330b071078294c08dd5f586666aa48b683c on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
Coverage decreased (-0.6%) to 71.094% when pulling 2688d84b74576be0e57d4ab5854e05f0741be85a on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
@Shashi-Bhushan Please also include jira ticket number at the beginning of every commit. This makes the commit history easier to read. Thanks.
@mmajchrzak Added a new Util method SliceTagUtils#getFromCurrentPath(PageContext, String, String), Also commented out the Failing Test case for now. Will include it after a final implementation of the method in SliceTagUtils.
Coverage decreased (-0.6%) to 71.049% when pulling 391e3d08220940cc02a03233fc897285ebc5ac98 on Shashi-Bhushan:SLICE-128 into fe0b2f7a8755b4b1f1163f80a9009905b8c076c5 on Cognifide:master.
Coverage decreased (-0.9%) to 70.781% when pulling 3b39c6f7c1426cd85db72166b1da3408eed7b1fc on Shashi-Bhushan:SLICE-128 into 433f18b12dbc92bdd12dcefcec1e34537c8bfa72 on Cognifide:master.
Coverage decreased (-0.9%) to 70.781% when pulling 3b39c6f7c1426cd85db72166b1da3408eed7b1fc on Shashi-Bhushan:SLICE-128 into 433f18b12dbc92bdd12dcefcec1e34537c8bfa72 on Cognifide:master.
Coverage decreased (-0.9%) to 70.781% when pulling 3b39c6f7c1426cd85db72166b1da3408eed7b1fc on Shashi-Bhushan:SLICE-128 into 433f18b12dbc92bdd12dcefcec1e34537c8bfa72 on Cognifide:master.
@mmajchrzak I've updated SliceLookupTag.java. The setter can be now be used for String as well, but as you specified because major version has been incremented, this will probably go into master when it's time for 5.0 release. Removed unnecessary Test case as well.
Additionally, I've been wanting to write a test case for slice:lookup tag test, using JspTagTrait. Could not use JspTagTrait it being an interface in Prosper-3.0(it's a Groovy trait in later versions, apologies I've never used interface version of this). If you could point me towards how i can write a test case for this now, i would be happy to write the test case as well.