Adam McArthur comments

Results 157 comments of


                                            Adam McArthur

use errgroup for recordset metrics

Hi @us0310306, we require commits to be signed. You will need to add a GPG key and force commit your changes. Without that, I do not have permissions to merge...

use errgroup for recordset metrics

Thank you @us0310306 !

use errgroup for recordset metrics

@us0310306 quite a few of these seem reasonable changes to make. Its interesting that the indentation errors are currently missing from our CI checks - I'll look into that

Fix Nova Pain-Points

I think as a first step, replicating this in a CI devstack should help.

Okay so https://github.com/openstack-exporter/openstack-exporter/issues/249 looks like part of the root cause to. Openstack-exporter is still using Gophercloud v1 everywhere except Ironic. This is probably priority #1 to fix issues.

Fix Nova Pain-Points

I would suggest that we also attempt to have consistent micro-version pinning across the repository to stop these issues happening invisibly.

Fix Nova Pain-Points

@vooon that is a great find, thank you. Let's use this going forward :)

Fix Nova Pain-Points

@vooon lets file this under a separate issue, since this ticket is nova painpoints specifically.

Looking for more Nova and Neutron metrics

Hey @NileshChandekar , I am in the process of a Gophercloud V2 Migration that should help get some of these metrics in. I will add it to the EPIC for...

openstack_nova_quota* metrics failed to collect due to caching issue

Hi @EnDjeee. Great find, and a PR sounds great :)