Adam McArthur
Adam McArthur
@evkuzin I will get on this PR ASAP - apologies for the delays I would appreciate reviews on the other priority-labelled tickets if you have the time so I can...
Note that `NewServiceClientV2` is only used by baremetal, but I have written it to include all services for future use. Also let me know if you would like the changes...
@niedbalski that should be it now :))
```bash ╭─coder@coder-sharpz7-main ~/projects/openstack-exporter ‹node-retired› ╰─➤ git rebase origin/main Current branch node-retired is up to date. ```
That is it all cleaned up :))
```go ╭─coder@coder-sharpz7-main ~/projects/openstack-exporter ‹node-retired› ╰─➤ go test ./... ? github.com/openstack-exporter/openstack-exporter [no test files] --- FAIL: TestOpenStackSuites (0.08s) --- FAIL: TestOpenStackSuites/TestNovaExporter (0.01s) nova_test.go:146: Error Trace: /home/coder/projects/openstack-exporter/exporters/nova_test.go:146 Error: Received unexpected error: Diff:...
Hey, I will first say that if `mapToString` gets 100% coverage already with its current integration in the test suite, you can ignore this comment. Its more of a `nit`...
I want to get https://github.com/openstack-exporter/openstack-exporter/pull/378 merged first, and then I will look into this, timeboxed to a couple of hours.
https://github.com/gophercloud/gophercloud/blob/master/docs/FAQ.md#implementing-custom-objects
Code being changed: https://github.com/openstack-exporter/openstack-exporter/blob/main/exporters/ironic.go#L17