Adam McArthur
Adam McArthur
Looks good - I think with a few fixes and a quick change to the heat test fixture, tests should pass. I think I would feel more comfortable merging this...
@vooon I don't have that either, but the CI is pretty good right now. If you don't mind, I can work on this PR after I get the integration tests...
Sounds good - might take me a while to get to but hopefully not too long, I think you have done a large chunk of the work already :)
Hey @vooon ! Thank you so much with this. I am stuck with a lot of academic work right now, but will review soon. As requested, I will run copilot...
Yes @vooon! I view this AI stuff as "the worst it will ever be" - I think eventually it will be really helpful! Meanwhile I'll work on #481
This is copying a significant amount of code from https://github.com/gophercloud/gophercloud/tree/main/internal/acceptance. I am going to create a ticket there about potentially trying to expose this code out instead of copying it.
| Service | Test Name | Coverage | |---------|-----------|----------| | Baremetal (Ironic) | `TestBaremetalIntegration` | `openstack_ironic_node` metric with labels (console_enabled, deploy_kernel, deploy_ramdisk, id, maintenance, name, power_state, provision_state, resource_class, retired, retired_reason);...
I think the main thing to not is BASIS_OPS for ironic is false. For some reason, this makes the tests pass, where they didn't before
@vooon - I'd appreciate your feedback on this in any capacity
@vooon appreciate this. Thank you!