Shaopeng (Chris) Lin

Results 28 comments of Shaopeng (Chris) Lin

Would love to work on this. I am thinking of using QSettings to retrieve web view URLs from tab bar class either on close or during each tab opening/closing(each tab...

This PR would solve the issue. There is an explicit check that tells the button to not switch if the search bar has text (so it doesn't remove the text...

~Just a thought, could an installer solve the issue? https://doc.qt.io/qtinstallerframework/ifw-overview.html.~ Nvm its a commercial license feature...

@kelson42 Are you aware if this PR or "Carried over bugfix" is related to any other existing issues? I don't seem to find any.

I think its doable. Just to clarify do you want it inside the search bar? Do you want a seperate PR for this? If we want it done in the...

@kelson42 One thing to note, Chrome browsers all have *Ctrl + D* as the bookmark as a bookmark shortcut. This shortcut is taken already by the donation shortcut. This might...

Found a bug that mouse clicks to the button is falling through to the line edit. Working on a fix...

Since we might be adding a multi-zim search button as well later into the search bar, the search bar looks more like a sub-toolbar of the top widget. I am...

@kelson42 If we were to re-open all tabs(including invalid ones), should we have a designated, "404 not found" page? Or should we just leave it blank? Also tagging @mgautierfr since...

If I get it correctly, we can simply open them as blank pages at the moment. We can achieve the functionality first and then open another issue for creating dedicated...