kiwix-desktop
kiwix-desktop copied to clipboard
kiwix
Bookmark icon not always available
I am using version 2.2.1 on Linux. When I click on a link in a book, an icon appears to the left of the title that allows me to bookmark it:
Alternatively, it is possible to search pages and then select one of the search results. Then the article is loaded, but no bookmark icon appears to the left of the title:
Trying to make the icon visible by pressing the escape key or clicking in the article does not work. The only solution I have found is to click on an arbitrary link in the article I want to bookmark, and then return to the previous article (Alt-Left). Only then does the icon appear.
I would expect that after clicking on a search result, the magnifying glass icon is replaced by the bookmark icon and the cursor disappears. This is not the case - instead you can even continue typing, which makes no sense because you have selected a search result.
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
Well Interesting to work on this bug @kelson42 Can I take this responsibility to fix this problem?
Can I do this in Window OS?
On Fri, 24 Mar, 2023, 12:12 pm Kelson, @.***> wrote:
@thestarsahil https://github.com/thestarsahil Yes, if you know how to fix it.
— Reply to this email directly, view it on GitHub https://github.com/kiwix/kiwix-desktop/issues/832#issuecomment-1482329214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUCES6W3SXXR3HGHNJ7IV2TW5U66NANCNFSM5TL7SRWQ . You are receiving this because you were mentioned.Message ID: @.***>
So both thestarsahil and LadyDhaga would like to work on a bugfix? That is good news because when working with bookmarks, at least for me, it is a usual workflow to bookmark something after searching for it – which does not work because of this bug. @thestarsahil I am using kiwix under Linux, but it should be easy to see if the problem occurs under Windows and MacOS. If you like, I can check both for you. At least on Linux, version 2.3.1, the problem still occurs, I just checked it:
@h-b Stefan Can I work on PopOs Version 22.07 system? If Yes Then I have to Install that Linux PopOs
@thestarsahil Thank you for your interest in working on the bug fix for this issue. As far as I understand, the bug seems to affect all operating systems, and the main goal is to resolve the issue in the project, regardless of the specific OS used for testing. However, I am not a maintainer or collaborator of this project, so I may not be the best person to answer your question about working on the Pop!_OS version.
I would suggest reaching out to the maintainers or collaborators of the project for further guidance on this matter. Meanwhile, you may proceed with testing the bug on any operating system you have access to and submit a pull request with your proposed fix. This would allow the project team to review and potentially approve your contribution.
Good luck, and I hope to see this issue resolved soon!
Stefan
@thestarsahil Thank you for your interest, but why you just not try first to compile the source code and reproduce the bug? This is how it works. People are short on time and want to discuss concrete proposals.
This PR would solve the issue. There is an explicit check that tells the button to not switch if the search bar has text (so it doesn't remove the text and replace it with the current page title). The check should not be relevant to when the button should switch so I separated the two. Though I feel like the button could be more easily managed as a separate button..., discussion for another time.
