Shankhanil Saha

Results 22 comments of Shankhanil Saha

> [@ShankhanilSaha](https://github.com/ShankhanilSaha), would this issue be interesting to you? Hi @adhiamboperes ,gave it a look. Sure would love to help and contribute to oppia by fixing this issue. You can...

Hi @adhiamboperes, the tests are primarily failing because of the tests in `utility/src/test/java/org/oppia/android/util/profile/ProfileNameValidatorTest.kt` should i completely remove the tests which are verifying names which were formerly allowed? or should i...

@adhiamboperes could you please check the error logs once, some tests were failing previously so i fixed them by changing the functions to `addAdminProfileAndWait()` which fixed the issue of the...

@adhiamboperes upon making the file changes in this PR a few tests fail in `app/src/sharedTest/java/org/oppia/android/app/onboarding/CreateProfileFragmentTest.kt` and `testing/src/test/java/org/oppia/android/testing/profile/ProfileTestHelperTest.kt` even tho tests are unrelated to the changes since they don't use any...

Hi @adhiamboperes , in `CreateProfileFragmentTest` and `ProfileTestHelperTest`, the appropriate files are not loaded for the `addAdminProfileAndWait()` function. However, `profileTestHelper` has another function `addOnlyAdminProfile()`. Unlike `createDefaultAdminProfile()`, this starts the setup fresh...

Hi @adhiamboperes could you please let me know about the new function replacing the `createDefaultAdminProfile()` in brief.

Hi @adhiamboperes , i am primarily referring to the `addProfile()` fucntion in the `ProfileManagementController` [file](https://github.com/oppia/oppia-android/blob/develop/domain/src/main/java/org/oppia/android/domain/profile/ProfileManagementController.kt) as it is somewhat similar to the function I need to make. Had some questions...

Hi @adhiamboperes , for checking if there are no existing profile ``` if (it.profilesCount > 0) { //Returns in case profiles return@storeDataWithCustomChannelAsync Pair(it, ProfileActionStatus.PROFILES_EXIST) do exist in the db }...

Also this is my proposed function, i just took `addProfile()` as a reference. Could you please take a look and let me know the changes needed? ``` fun createDefaultProfile(): DataProvider...

@adhiamboperes The function is created and applied in the necessary places, Please take a look. Also the tests seem to be failing again for those dependencies download issue.