oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Move InteractionObjectTestBuilder to a main-level testing library

Open BenHenning opened this issue 5 years ago • 7 comments

InteractionObjectTestBuilder is a non-test file under the test directory. Test utilities should be in a testing directory under main, not test, or be in the dedicated testing module.

This issue can be resolved by moving this file to package org.oppia.android.app.player.state.testing.

  • All usages must have the imports updated(automatically done by Android Studio).
  • Ktlint formatting check java -jar ../oppia-android-tools/ktlint -F --android domain/src/**/*.kt utility/src/**/*.kt data/src/**/*.kt app/src/**/*.kt testing/src/**/*.kt scripts/src/**/*.kt instrumentation/src/**/*.kt should be run to ensure unused imports are removed, and imports are ordered correctly.
  • Tests using this util should build correctly in Bazel and Gradle.

BenHenning avatar Nov 21 '20 00:11 BenHenning

Please assign this to me

FareesHussain avatar Nov 24 '20 12:11 FareesHussain

Unassigning myself making it available for new contributors

FareesHussain avatar Jan 21 '21 02:01 FareesHussain

@BenHenning please update the Title as this is blocked on #1904

FareesHussain avatar Jan 21 '21 02:01 FareesHussain

hi @BenHenning assign this issue to me

manan1979 avatar Mar 23 '23 17:03 manan1979

@manan1979 thanks for showing interest in this issue! Could you provide a basic outline of how you plan to tackle this issue, first? That way we can be sure you're approaching it in a way that should work.

BenHenning avatar Mar 24 '23 02:03 BenHenning

I would like to help complete this task and ensure the library is designed for broad reusability in tests.

akshtshrma avatar Dec 04 '24 18:12 akshtshrma

@adhiamboperes I have submitted a PR for this issue, can you please approve it.

akshtshrma avatar Dec 05 '24 08:12 akshtshrma

@ShankhanilSaha, would this issue be interesting to you?

adhiamboperes avatar Oct 16 '25 11:10 adhiamboperes

@ShankhanilSaha, would this issue be interesting to you?

Hi @adhiamboperes ,gave it a look. Sure would love to help and contribute to oppia by fixing this issue. You can assign it to me.

ShankhanilSaha avatar Oct 16 '25 15:10 ShankhanilSaha