Shane Krueger

Results 854 comments of Shane Krueger

Federation 2 support is available for schema-first, code-first, and type-first schemas in GraphQL.NET 8.0 (still in beta at the time of writing). See: - https://github.com/graphql-dotnet/graphql-dotnet/pull/3921 This includes proper support for...

I took a look at this today. So far I don't see this as a good solution if it requires people to use AddField rather than the field builders. This...

It's also possible that I misunderstand your changes from my very-brief scan of the changes. I would like to see a sample of what changes are required for a typical...

It seems that you wrote another field builder, but unless I'm wrong, there's no way to use it. Let's assume you fix that issue. It seems like a lot of...

All my comments apply equally to changes towards the goal of having input types disallow resolvers (which I endorse): the goal is met if compile-time restrictions are in place. Otherwise...

Another thing I'm thinking, is that the subscription field type inherits from `FieldType`, so it could be assigned anywhere that `FieldType` is allowed. In other words, a stream resolver could...

> > However, these changes might be drastic to implement. > > I needed to start with something and I took the first step. Inheritance hierarchy looks like the second....

I need time to review. Looking over only the API changes, I was thinking that perhaps there is an opportunity to turn some field builder methods into extension methods and...

Note that I think this PR is on the right track, but we should be careful to merge without a full review.

Extension methods can still do this: ```cs public static TBuilder DoSomething(this TBuilder builder /* additional params */ ) where TBuilder : IFieldBuilder { /* do something */ return builder; }...