Shane Krueger

Results 854 comments of Shane Krueger

Just a quick thought: I think we have to consider the fact that the current implementation within MS's libraries are based on older technology simply because their library is older....

> I updated PR, making it closer to real needs. How so? All it tracks are schema created and initialized events, which typically only occur once per application lifecycle! So...

Also this is not configurable as designed. Within #3467 we implemented it as opt-in so it can be configured or left disabled. Here it's built-in. Why the difference?

I don't get it. Perhaps in the PR description you should state what this PR's intent is and/or what it does. I certainly would not add `EventSource` just to log...

I'm so pressed for time I may not have read this PR fully.

If we want built-in counters and etc, perhaps we should consider adding a dependency on [System.Diagnostics.DiagnosticSource](https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource) for v8 and using the most modern framework rather than using an outdated pattern.

@sungam3r Shall we close this or do you have a suggestion here? From the original issue, I would say it's as-designed. Now we have field builders which can infer the...

It is important to distinguish the use case -- for output fields vs inputs fields. Input fields require an `Expression` in order to map the property. Output fields should allow...

> My whole idea for fields API - make it as minimalistic as possible (4 overloads maybe?) on GraphType classes moving all additional configuration as fluent API in builders. I...

@gao-artur You might be interested in the latter half of this old thread, if you've not seen it before.