Shahzaib Ibrahim
Shahzaib Ibrahim
> I see that this PR changes (all?) calls to `OS.GetSystemMetrics` for a call to a new intermediate method in `Widget`: why not simply change `OS.GetSystemMetrics` and put the new...
> 2. What would happen if one removes the `if (OS.WIN32_BUILD >= OS.WIN32_BUILD_WIN10_1607)` in the new method and always calls `OS.GetSystemMetricsForDpi(...)`? Would the application crash in older Windows versions? I...
> Maybe I'm testing it wrong? No you have tested it correctly. I just forgot to mention that you need to add these vm arguments while running the example. -Dswt.autoScale=quarter...
> I tested it again and I still see no difference between before and after this PR. Moreover, the status **before** this PR looks OK (I see both scroll bars...
> Thanks for the proposal! It makes sense to have all toggle options uniformly prefixed with "toggle" to make the effect easier to understand. > > Here are some remarks...
> 4. There seems to be explicit documentation for this action, which probably has to be updated when changing the action name, e.g.: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/4b5fccff1c7878e02430c22ede26c8788c60896e/eclipse.platform.common/bundles/org.eclipse.jdt.doc.user/reference/views/breakpoints/ref-skipall_viewaction.htm#L8 https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/1559
> @HeikoKlare anything left here to do for @ShahzaibIbrahim? @vogella Yes, I have found the existing ticket for this particular issue (See: https://github.com/eclipse-platform/eclipse.platform.swt/issues/501) and the toggle "state/highlight" issue is for...
> Please check your latest commit. Only considering the diff, it does not seem to be in the intended/final state. There is a `System.out.println()` statement and some some added magic...
> @ShahzaibIbrahim can this one be closed? It seems as if all of the places touched in this PR have meanwhile been revised anyway. Yes, we can close this one.
Can I have more info on this? I tried reproducing on latest build with no VM arguments, Windows 11, Screen Resolution 1920x1080 and zoom level 100%. I am unable to...