eclipse.platform.swt icon indicating copy to clipboard operation
eclipse.platform.swt copied to clipboard
verified publisher icon eclipse-platform

Replacing the usage of getBoundsInPixels with getBounds

Open ShahzaibIbrahim opened this issue 1 year ago • 1 comments

Initial native image must be the one that will be used by a widget, thats why using getBounds with initialNativeZoom. This PR just remove the usage of deprecated method getBoundsInPixels wherever possible. This doesn't fix anything broken.

ShahzaibIbrahim avatar Aug 06 '24 11:08 ShahzaibIbrahim

Test Results

  284 files   -   201    284 suites   - 201   5m 6s :stopwatch: - 3m 45s 4 158 tests ±    0  4 150 :white_check_mark: +    1   8 :zzz: ± 0  0 :x:  - 1  8 246 runs   - 8 140  8 188 :white_check_mark:  - 8 105  58 :zzz:  - 34  0 :x:  - 1 

Results for commit 2bc50897. ± Comparison against base commit 02e20d69.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 06 '24 11:08 github-actions[bot]

@ShahzaibIbrahim can this one be closed? It seems as if all of the places touched in this PR have meanwhile been revised anyway.

HeikoKlare avatar Mar 11 '25 11:03 HeikoKlare

@ShahzaibIbrahim can this one be closed? It seems as if all of the places touched in this PR have meanwhile been revised anyway.

Yes, we can close this one.

ShahzaibIbrahim avatar Mar 11 '25 12:03 ShahzaibIbrahim