Grigorii K. Shartsev

Results 583 comments of Grigorii K. Shartsev

> > * allow to manually unmount (use case?) > > You were the last person used it =D > > https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/main/lib/dialogs.ts#L80 @susnux Could you confirm this use case is...

> You mean that we should have a hide function? This is basically the only use case why I added the possibility to unmount in the orginal `spawnDialog` 😅 Yes....

> The use case with accessing the apps stores is pretty usual, in this case you need to explicitly pass the Pinia you want to use. Pinia should work out...

> Personally I prefer simple return types like an object thats alway the same like above. Then it's always overloaded only to support a rare case

> Is something left [@ShGKme](https://github.com/ShGKme) ? Backport forward compatible version to v8 👀

I'd like to backport Promise API in a non-breaking way for forward compatibility. I have a draft left from this option in the next version.

`submit` is an event of a `form` element, not an `input` element. So using Enter for submitting is a form's feature. `trailing-button-click` doesn't always mean "submit". It might be "clear",...

Closing. Feel free to reopen if still actual or there are new thoughts

I see the same problem in many apps/web-sites with contenteditable in Chromium browsers...

> Should we do it all the time (without props)? Or if href doesn't match content? Then it duplicates already existing web-browser feature