nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

fix(NcRichText): show links title for desktop client

Open DorraJaouad opened this issue 1 year ago • 4 comments

☑️ Resolves

  • Fix https://github.com/nextcloud/talk-desktop/issues/320

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • [ ] ⛑️ Tests are included or are not applicable
  • [ ] 📘 Component documentation has been extended, updated or is not applicable
  • [ ] 3️⃣ Backport to next requested with a Vue 3 upgrade

DorraJaouad avatar Oct 02 '24 06:10 DorraJaouad

Should we do it all the time (without props)? Or if href doesn't match content?

Antreesy avatar Oct 02 '24 07:10 Antreesy

Should we do it all the time (without props)? Or if href doesn't match content?

Then it duplicates already existing web-browser feature

ShGKme avatar Oct 03 '24 15:10 ShGKme

Or if href doesn't match content?

I say we keep the same for all links

DorraJaouad avatar Oct 03 '24 18:10 DorraJaouad

Then it duplicates already existing web-browser feature

True. I couldn't find any related options or preferences in Electron app, but that anyway should be done in talk-desktop repo, I believe. Another point of doing that is that we have links outside of NcRichText (as conversation links, settings redirects)

Maybe we can implement it with a custom solution, like:

  • add listener on hover
  • if it's a link, draw a preview box in the corner

Antreesy avatar Oct 07 '24 10:10 Antreesy

Then it duplicates already existing web-browser feature

Sounds like we do not want this? If I am wrong please reopen

susnux avatar Jul 16 '25 15:07 susnux