Alex

Results 84 comments of Alex
trafficstars

Tags embed the full image file, if you need it decoded you should check out the [image crate](https://crates.io/crates/image).

If you're still working on this, just wanted to let you know https://github.com/Serial-ATA/lofty-rs/commit/1d5d397dfa2ceea75c7ed9fefecb45c81af6da8d should invalidate https://github.com/Serial-ATA/lofty-rs/pull/51#discussion_r873170767 for the most part. I noticed TagLib still produces different numbers, but far less...

Sure, I'll look into this for 0.9.0 :slightly_smiling_face:.

I really like that idea. I think it could be better than having to set a bunch of options.

Hm, I hadn't thought about setting a MSRV. While I don't want to speak too early, I don't *think* it'll need to go above 1.57 anytime soon, since I just...

Hey @jonathanlermitage, have you looked into this? It looks like this might not be possible: https://github.com/mallowigi/a-file-icon-idea/issues/146#issuecomment-766297286.

Hm, not sure how to best go about this. Maybe `ID3v2Tag::set_version`?

Allowing two different versions of the tag would complicate things quite a bit, [even TagLib upgrades all tags to 2.4](https://github.com/taglib/taglib/blob/4e7f844ea6439a5a90546feba359832b2ce2e2e8/taglib/mpeg/id3v2/id3v2header.cpp#L160-L161). TagLib lets you change the version [with overloading](https://taglib.org/api/classTagLib_1_1MPEG_1_1File.html#a9de209d59cd79935b9eae27cfadb1a9b), so maybe...

The conversion isn't *completely* lossless, some frames have a 1:1 mapping and others have expanded in 2.4. The discarded frames aren't that important though IMO, I doubt most apps even...

Thanks! It might be better to use `Popularimeter::as_bytes` and store it as `ItemValue::Binary` to preserve the other fields, just in case they're written. Could you also document the behavior [here](https://github.com/Serial-ATA/lofty-rs/blob/cffc8182e13e908cc707c2d5bd9246e12caec67a/src/id3/v2/tag.rs#L87)?...