lofty-rs icon indicating copy to clipboard operation
lofty-rs copied to clipboard

Add tests from taglib

Open sagudev opened this issue 3 years ago • 2 comments

Currently test are on ignore as they are not working due to lofty.

sagudev avatar May 15 '22 08:05 sagudev

If you're still working on this, just wanted to let you know https://github.com/Serial-ATA/lofty-rs/commit/1d5d397dfa2ceea75c7ed9fefecb45c81af6da8d should invalidate https://github.com/Serial-ATA/lofty-rs/pull/51#discussion_r873170767 for the most part. I noticed TagLib still produces different numbers, but far less frequently.

Serial-ATA avatar Jun 22 '22 22:06 Serial-ATA

If you're still working on this, just wanted to let you know 1d5d397 should invalidate #51 (comment) for the most part. I noticed TagLib still produces different numbers, but far less frequently.

It would probably be the best to implement something like assert with delta, something that is used for floats that permits ±1.

sagudev avatar Jul 11 '22 14:07 sagudev

Hey @sagudev, do you mind if I take this over? :slightly_smiling_face:

Serial-ATA avatar Jan 05 '23 19:01 Serial-ATA

Hey @sagudev, do you mind if I take this over? 🙂

You may take this over; unfortunately it's been low on my priority list.

sagudev avatar Jan 06 '23 04:01 sagudev

Alright, thanks for your work on this!

Serial-ATA avatar Jan 07 '23 03:01 Serial-ATA