Jordi Boggiano comments

Results 898 comments of


                                            Jordi Boggiano

Use Promise::done where possible, upgrade react/promise to allow v3

> This one has been something we've discussed a lot and it breaks down to this: Effectively a void method translates to a `null` return so the promise `PromiseInterface`. We're...

Use Promise::done where possible, upgrade react/promise to allow v3

Ok I kept the type as `PromiseInterface` for now, because it was just too ugly to add return null everywhere for no good reason.. IMO it'd be nice if there...

Use Promise::done where possible, upgrade react/promise to allow v3

> Semantically, the above holds true and is what should be relied upon. On a functional level, you're indeed right that a `PromiseInterface` does in fact pass a `null` value...

Use Promise::done where possible, upgrade react/promise to allow v3

Yeah I guess not worth adding a `resolveVoid()` which would kinda be the only way to separate creating a `PromiseInterface` from a null one with `resolve()`. So let's bury this,...

when my gitlab domain is git.example.org,clone fail

See my comment above.. I don't think anything needs fixing on our side.

Security Advisory Features

Does this really matter tho? Ensuring package integrity is great but signing this API seems kinda pointless. And no, there is no way to prevent this right now, if an...

ErrorException: Caught ErrorException (HTTP/1.0 500 Internal Server Error): fwrite(): write of X bytes failed with errno=32 Broken pipe

Sorry but until someone gets to the bottom of this, I doubt I can do much. I'm not sure why this seems to be an issue with Laravel and not...

ErrorException: Caught ErrorException (HTTP/1.0 500 Internal Server Error): fwrite(): write of X bytes failed with errno=32 Broken pipe

Bumped Monolog to 2.9.2 from which version? If you can try to downgrade it again and that fixes it at least it'd give us a range of changes to look...

ErrorException: Caught ErrorException (HTTP/1.0 500 Internal Server Error): fwrite(): write of X bytes failed with errno=32 Broken pipe

Ok, that might be due to this change which would have made it swallow errors in some cases before? https://github.com/Seldaek/monolog/compare/2.9.1...2.9.2#diff-a1ddc5c4ead6773b8670f9be5007cbe0239638aedbcf12166acf075a9b8742a2 see also https://github.com/Seldaek/monolog/pull/1815

ErrorException: Caught ErrorException (HTTP/1.0 500 Internal Server Error): fwrite(): write of X bytes failed with errno=32 Broken pipe

Seems unlikely to me that this is it but who knows. Anyway would be good to know if it's 2.9.2 which caused it or you upgrade to PHP 8.1