Jordi Boggiano comments

Results 900 comments of


                                            Jordi Boggiano

[Logging] Document the Monolog reset() for long running processes

Yes I believe so as of https://github.com/symfony/symfony/pull/40761

[HttpFoundation] Add method `getString` to `ParameterBag`

I think you mean https://github.com/symfony/symfony/pull/48525

MonologBridge shows deprecation error with Monolog 3.2

I don't know if you have a way to ignore these errors, but just FYI the reason I added the `@final` was because some people extended it and did crazy...

MonologBridge shows deprecation error with Monolog 3.2

Yeah that'd be a better outcome but I also see it seems like work which isn't strictly needed so I wanted to clarify.

[Help Wanted] Increasing test coverage of Command classes

@siims-biz yes the list in https://github.com/composer/composer/issues/10796#issuecomment-1277340969 above is still more or less accurate

[Help Wanted] Increasing test coverage of Command classes

@siims-biz knowledge of PHPUnit, some knowledge of composer (from user perspective good, internals better), the easy ones have been covered already though so if you aren't super familiar with all...

[Help Wanted] Increasing test coverage of Command classes

54.4% now, thanks everyone involved so far! Here are the classes still needing the most effort, but overall we are really in a much better spot now I would say...

Add possibility to specify the path of an auth.json

Do you have a chance to pass env vars easily? Because you could read the user auth.json into COMPOSER_AUTH env var and make that available in docker, then it should...

Use Promise::done where possible, upgrade react/promise to allow v3

Yup I've seen that, thanks! It's on my list for next week

Use Promise::done where possible, upgrade react/promise to allow v3

Some feedback @WyriHaximus @clue: - Overall this looks great IMO, thanks! - resolve() requires an arg which is fine by me, but that means when you use it you always...