Ze-Zheng Wu
Ze-Zheng Wu
> Whoops, my bad. It was definitely because I find/replaced that text. Do you have a better way of doing these kinds of large codemods? I'm not aware of any...
From the [W3C spec](https://www.w3.org/TR/html-aria/#el-autonomous-custom-element), autonoumous custom elements can have any role or none, so I think it's reasonable to ignore custom elements in this rule.
They're actually issues in our source code, so I reopened this. This is an easy fix, do you want to send a PR? @chekrd https://github.com/biomejs/biome/blob/b33c9dfe723a53ff5ad786800be9fca73d4c8770/crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html.rs#L32 https://github.com/biomejs/biome/blob/c180aacf708d2e56753dfc93c24d9dada639c8be/crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html_with_children.rs#L41
Or we can take a further step to utilize our analyzer to emit warnings if a rule is unnecessarily specified without customized options when it is already included in the...
> Ideally we should normalize all path to absolute path and turn relative glob patterns into absolute glob patterns. I think this is the right direction to go. But I...
> @Sec-ant > > Few months ago I tried to use globset and that broke a lot of user's code. We had to revert that. It misses an important functionality...
Absolutely, just share some findings!
I can reproduce this issue. According to the [TypeScript document](https://www.typescriptlang.org/docs/handbook/2/modules.html#how-javascript-modules-are-defined): > Conversely, a file without any top-level import or export declarations is treated as a script whose contents are available...
I think this is because the root directory detection (`cwd`) has different results in CLI, LSP and git hooks. I will look into this issue.
I did some debugging but couldn't find time to implement the fix, others are welcome to tackle it. Here is what I found: 1. The problem is not only about...