refactor(codemod/biome_js_analyze): remove manual construction of `JsRuleAction`
Summary
This is a follow up to #2820.
Related to: #2799
Test Plan
It compiles, tests pass.
CodSpeed Performance Report
Merging #2874 will not alter performance
Comparing dyc3:05-12-refactor_codemod_biome_js_analyze_remove_manual_construction_of_jsruleaction_ (243c60c) with main (d9e1873)
Summary
✅ 99 untouched benchmarks
CI is failing due to clippy error
cc @dyc3
Fixed in https://github.com/biomejs/biome/commit/7bcc112067a6fdb7c4dc48056c9d49b7dbbcf51d
Whoops, my bad. It was definitely because I find/replaced that text. Do you have a better way of doing these kinds of large codemods? I'm not aware of any tools that do that
Whoops, my bad. It was definitely because I find/replaced that text. Do you have a better way of doing these kinds of large codemods? I'm not aware of any tools that do that
I've never used it in repos like biome but you can try gritql which is also what biome plans to use to support plugins.
Anyway these kind of errors are supposed to be catched by tests, it's just a limitation of our current setup (main repo + website repo codegen) which makes these kind of errors more difficult to avoid.