Ze-Zheng Wu
Ze-Zheng Wu
> script tag cannot be self-enclosing I think this is only true in HTML? But this rule is only enabled in JSX, and JSX transpiler should transpile them into the...
While I was working on #3317, I noticed some code that might be related to this issue: https://github.com/biomejs/biome/blob/3c23f599d96a67e4a32e296c0419006b3e82a835/crates/biome_service/src/matcher/mod.rs#L104-L115 I think it was meant to be `starts_with`, but that will still...
> Should the first or second/last overload signature be replaced with the unified one (and the other removed)? I don't think we have much choice because a function implementation has...
I agree what you said above. I just want to add one more thing: for JSDoc/TSDoc comments, they may have parameters and types to describe the function signature, so renaming...
FYI, there're some pre-discussions here: #2620
This was an intended behavior introduced in https://github.com/biomejs/biome/commit/4f1e9cd0674c950bb16a3bfee49e555ed5d5f7a6 Part of the reason of this behavior was to fix the unstable code actions that PR #2237 was trying to fix. However...
> Interesting, perhaps a quick fix to this issue would be to mark the fix as "unsafe" if it would remove a comment, to encourage manual review. Yeah but that...
I created #3317 @dyc3, I think it already addressed this issue. But there's a bigger refactoring task behind. Feel free to get involved. There're some discussions at https://github.com/biomejs/biome/pull/3310
> Is this issue addressed by #3317? It will be, but given the scope of the refactoring, addressing merge conflicts has become more and more difficult with scattered commits, so...
> Would it be feasible to make this rule configurable to ignore some objects? I personally have no objection to that but would like to know how others see it....