Robert Russell

Use for loop, (void)

1

https://godbolt.org/z/rrnzhdoGn I just made some test code things appear to still work. ## Using for loop instead of while For loop can iterate and check the condition in the same...

https://github.com/codereport/An-Algorithm-Library/blob/1a94a025ad0a187cc0fd39bb6bcbc9a5791338b2/src/aal/algorithm.hpp#L9 If the user is using a `mutable` lambda. Then they can't use the algorithm. So might need to remove const from these. We might want to test a mutable...

AppVeyor was added with my Add Tests pull request. https://github.com/codereport/An-Algorithm-Library/pull/7 I'm not an expert on apple or clang. I might be able to get it to work via google. Anyone...

Add ut to project and create tests for each of the algorithms.

6

Add https://github.com/boost-ext/ut to the project to test it, and lead to having a CI run on it like it does for J. This will require compiler upgrades on to at...

Use cmake to import a test library. So we can add testing to the project.

3

I don't have much exp with catch2. Though I think it wouldn't take much work to setup. This site shows an example of how to add catch2 via cmake: https://cliutils.gitlab.io/modern-cmake/chapters/projects/fetch.html...

I used cmake fetchcontent to include your library to use with conan.

1

An old version is at: ```py self.requires("imgui-sfml/2.1@bincrafters/stable") ``` I think that bincrafters is being phased out. conan-center-index has these two packages. ```py self.requires("imgui/1.84.2") self.requires("sfml/2.5.1") ``` I was trying to use...

Problem: - [compiler-warning-level-4-c4702](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4702?view=msvc-160) would trigger on the default/second `return` statement in MSVC when compiling in release mode. At first I tried just moving the `return` statement to inside the `try`...

## Expected Behavior No warnings. ## Actual Behavior Multiple shadowing of names in code. I have to enable `-Wno-error=shadow` with `-Werror` or I couldn't compile. ## Steps to Reproduce the...

Unreachable code shows in MSVC 16.9.5 in release mode.

1

## Expected Behavior Compile like it does in debug mode. ## Actual Behavior Had error with /WX on. ## Steps to Reproduce the Problem 1. I switched to release mode....

## Article https://devblogs.microsoft.com/cppblog/code-scanning-with-github-actions/ ## Link to enable. https://github.com/MaKiPL/OpenVIII-monogame/new/master?filename=.github%2Fworkflows%2Fcodeql-analysis.yml&workflow_template=codeql&code_scanning ## Reason This basically builds and scans the code for known security issues. You get a green check mark if it succeeds...