Sébastien Beyou comments

Results 178 comments of


                                            Sébastien Beyou

Prevent doubled output if hook is called repeatedly

Searching a bit more, indeed there might be two executions of the hook SkinAfterBottomScripts between 1.37 included and 1.39 included, but there is only one execution in 1.40 and 1.41....

Prevent doubled output if hook is called repeatedly

Contrary to my previous comment, there is no issue in 1.37 and 1.38. The issue appears with 1.39.0 ([this commit](https://phabricator.wikimedia.org/rMW95a4189814e20b7754a0e4a576afbe2af4c50245)) and is present in 1.40.0. It was fixed in 1.39.5...

TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance of ParserOutput, bool given

I investigated this issue two days ago during a few hours, but did not find for now how to solve it. Below are some of my findings. First, to reproduce...

TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance of ParserOutput, bool given

I dived more deeply in this issue. After spending some hours in comparing stacktraces in 1.35 and 1.36 on the test LinksUpdateTest, I changed strategy and bisected the MW version...

TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance of ParserOutput, bool given

On MW 1.36 (last commit in REL1_36) + SMW master, PHPUnit executed locally dropped from: `Errors: 12, Failures: 16, Skipped: 53, Risky: 2` To (with MediaWiki\User\ActorStore::LOCAL_CACHE_SIZE = 0): `Errors: 1,...

TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance of ParserOutput, bool given

**EXPLANATION OF THE ISSUE:** I now have a rather precise idea of what is happening. To be again more precise in the conditions where is issue is happening, the following...

TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance of ParserOutput, bool given

The PR #5320 shows the influence of this ActorStore cache on SMW tests, with a patched version of MW where the cache is deactivated.

TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance of ParserOutput, bool given

I opened the Phabricator task [T320980 "Add parameters to control ActorCache"](https://phabricator.wikimedia.org/T320980) to request a parameter to disable this ActorStore cache. This issue can be closed as well as #5190 (I...

Add bot inclusion?

As a side note, MediaWiki bots (=users in the user group 'bot') are managed by the parameter `$wgMatomoIgnoreBots` (`true` by default). This task is about other bots.

Properly manage lists

@promethe42: it would be great if you can study it and we discuss @mdamien: FYI Also, I had to manage this same issue for alineas in `metslesliens`. It was a...