Sébastien Beyou
Sébastien Beyou
It finally worked: the main issue was that **the Elasticsearch server (v6.5.4) was not powerful enough**. After some time ingesting data, ES does some internal stuff (merging Lucene segments if...
> @Seb35 Did you get Elasticsearch 6.8.18 (the last one of the 6.x series), MW 1.35.3 (the last LTS) and SMW master working together? I could not make it to...
The issue comes from #4572: when it is reverted, all results are displayed. The right resolution remains to be find with a middle ground between the old behaviour and the...
More exactly the only thing to do is to comment, in `src/SQLStore/EntityStore/PrefetchCache.php`, function `prefetch` the instruction `return;` in the middle: ```diff diff --git src/SQLStore/EntityStore/PrefetchCache.php src/SQLStore/EntityStore/PrefetchCache.php index d928a2234..e22ae16a4 100644 --- a/src/SQLStore/EntityStore/PrefetchCache.php...
@mwjames: Studying more the commit #4572 and the class PrefetchCache, there are some things I don’t understand and probably some of them create this issue: 1. the function `isCached` only...
A better fix than my previous one is: ```diff diff --git src/SQLStore/EntityStore/PrefetchCache.php src/SQLStore/EntityStore/PrefetchCache.php index d928a2234..5ab8bc3b1 100644 --- src/SQLStore/EntityStore/PrefetchCache.php +++ src/SQLStore/EntityStore/PrefetchCache.php @@ -122,7 +122,7 @@ class PrefetchCache { // when called...
The linked PR fixes this issue and adds an optimisation for chained properties. This optimisation can be sensible when chained properties are heavily used.
I implemented a patch for this feature, for now still to be improved, I will try to put it in a “draft PR” soon. Currently my patch is a mix...
@mwjames: this is the logical continuation of #4572, could you review it?
I will add a test to catch issue 4988, probably by adding a new Ask request in p-0434.json or p-0467.json.