Sashan comments

Results 84 comments of


                                            Sashan

tcpdump should open file, where captured packets are going to be writ…

> > > The problem with this is that tcpdump opens files again with -C switches, and so really mechanisms were tcpdump has any privilege are broken. Your patch is...

test for HELP command needs to be updated

> There are many, _many_ changes to made to the integration tests -- what exactly are you wanting to accomplish with these PRs? at least just documenting the issue. I'm...

rang_retr_ok_no_sendfile unit test fails

the error also impacts `rang_retr_ok_end_exceeds_file_size` test which fails with message as follows: ``` Expected response message 'Transfer complete', got 'Abort successful' at /usr/perl5/site_perl/5.32/Error.pm line 461. ``` symptoms are identical, there...

rang_retr_ok_no_sendfile unit test fails

> This issue may indeed be related to the version of the Perl modules in use. What does the following show for you? > > ```shell > perl -MNet::FTP -e...

we should allow user to override default PROFTD_TEST_PATH

`ctrls_lsctrl_system_user_ok` and `ctrls_lsctrl_ok` tests in `t/modules/mod_ctrls.t` both fail with error as follows: ``` Executing ftpdctl: /scratch/userland-gate/components/proftpd/proftpd-1.3.8rc4/tests//../ftpdctl -s /tmp/proftpd-test-3509-test2-ulA38XKwoo/ctrls.sock lsctrl Can't exec "/scratch/userland-gate/components/proftpd/proftpd-1.3.8rc4/tests//../ftpdctl": No such file or directory at t/lib/ProFTPD/Tests/Modules/mod_ctrls.pm line...

use port as before calling to config_write()

> this is what happens when we run test as found in current master branch: ``` Failed 1/2 subtests Test Summary Report ------------------- t/signals/hup.t (Wstat: 0 Tests: 2 Failed: 1)...

use port as before calling to config_write()

> This issue should be fixed by [d9c8e67](https://github.com/proftpd/proftpd/commit/d9c8e6733ec47d7f36052bcacea78dfd32568a63) -- which includes a comment explaining why the first `$port` file needs to be used for this regression test. Thanks for the...