Sashan
Sashan
This PR should be close, because issue got fixed via #25792
New revision attempts to address comments raised by @t8m. In order to make evp_test to pass I had to introduce a _rounding_ I feel uneasy about this change. The `bits`...
> LGTM thanks for review, can you mark it as 'accepted'? thanks.
> Could you add the fuzzer-generated data as a testcase somehow? IMO it should fail import with openssl rsa (or openssl pkey) with the fix. Otherwise it should pass. I've...
> It seems the last fixup commit is a fixup to a different commit. Or just do not use a fixup commit but a regular one not to be squashed...
> > > It seems the last fixup commit is a fixup to a different commit. Or just do not use a fixup commit but a regular one not to...
Can you run test_store test in verbose mode and share output with us? The output will be long, so perhaps just attach it as a file. thanks. ``` export VERBOSE=1...
Sorry I've missed your mention on no failures when verbose mode is enabled. It makes no sense to share verbose mode output. interesting, so the failure happens if and only...
I think the PR needs rebase.
> Would it be possible to add a testcase? thank you for making me to write the tests, because this made me to discover those two functions which do exactly...