Sarah French
Sarah French
### What kind of contribution is this issue about? Other (specify in details) ### Details This code is where we register sweepers on the provider : https://github.com/hashicorp/terraform-provider-google/blob/56144d50cc96d04b86a6bdc17e4d57920ad596eb/google/sweeper/gcp_sweeper.go#L72-L76 [The resource.Sweeper struct...
### What kind of contribution is this issue about? Other (specify in details) ### Details The sweeper for `google_vmwareengine_external_address` resources doesn't work and [builds URLs like this](https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_SERVICE_SWEEPER__CRON/177455?buildTab=log&focusLine=677&logView=flowAware&linesState=658) when looking for...
### What kind of contribution is this issue about? Other (specify in details) ### Details The [sweeper for google_gkeonprem_vmware_node_pool resources](https://github.com/hashicorp/terraform-provider-google/blob/main/google/services/gkeonprem/resource_gkeonprem_vmware_node_pool_sweeper.go) creates URLs matching this template : "https://gkeonprem.googleapis.com/v1/projects/{{project}}/locations/{{location}}/vmwareClusters/{{vmware_cluster}}/vmwareNodePools" There isn't a...
### Community Note * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request. * Please do...
Update docs for using `google_project_service` to cover case where service account lacks permissions
### Community Note * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request. * Please do...
See https://github.com/hashicorp/terraform-provider-google-beta/pull/7582/files **Release Note Template for Downstream PRs (will be copied)** ```release-note:none ```
Fixes https://github.com/hashicorp/terraform-provider-google/issues/18574 Lots of generated VMware Engine sweepers don't work, and this impacts contributions related to VMware Engine. **Release Note Template for Downstream PRs (will be copied)** ```release-note:none ```
I was looking at https://github.com/hashicorp/terraform-provider-google/issues/17838 and realised that changing the tests there are tough because there are lots of arguments passed into config and formatting of the config string is...
Stacked PR on top of https://github.com/GoogleCloudPlatform/magic-modules/pull/10883 **Release Note Template for Downstream PRs (will be copied)** ```release-note:none ```
Hi there! Thank you for providing this GHA 🙏 Node 16 is becoming deprecated, see https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Just like [the previous jump to Node 16](https://github.com/uesteibar/reviewer-lottery/pull/40) in this project, there would need...