Sam Yuan comments

Results 244 comments of


                                            Sam Yuan

use matrix to avoid copy my self in github action(pipeline as) code

@denyeart , could you please ask some one take a look at this kind of idea? otherwise, I am going to close this pr.

use matrix to avoid copy my self in github action(pipeline as) code

> https://github.com/hyperledger/fabric/actions/runs/2939710490 ok, if it looks worth to discuss, I am going to rebase and update.

use matrix to avoid copy my self in github action(pipeline as) code

@denyeart , could you please help rerun azp check? and review this pr?

use matrix to avoid copy my self in github action(pipeline as) code

> this verify build run I suppose even if the jobs running in parallel, they still need to waiting for github agent ready to run the job.

use matrix to avoid copy my self in github action(pipeline as) code

As for sample: ``` Requested labels: ubuntu-22.04 Job defined at: hyperledger/fabric/.github/workflows/verify-build.yml@refs/pull/3617/merge Waiting for a runner to pick up this job... ```

use matrix to avoid copy my self in github action(pipeline as) code

> > As for sample: > > ``` > > Requested labels: ubuntu-22.04 > > Job defined at: hyperledger/fabric/.github/workflows/verify-build.yml@refs/pull/3617/merge > > Waiting for a runner to pick up this job......

use matrix to avoid copy my self in github action(pipeline as) code

> I would change line 16 to `GO_VER: 1.18` and line 21 to `runs-on: ubuntu-22.04` updated with environment value to control go version CI.

use matrix to avoid copy my self in github action(pipeline as) code

> Ok, based on the delay and large number of runners, and overhead per runner, I have to agree with Julian that it would be better to continue to group...

rpc error: code = Unavailable desc = closing transport due to: connection error: desc = "error reading from server: EOF", received prior goaway: code: ENHANCE_YOUR_CALM, debug data: "too_many_pings"root

``` rpc error: code = Unavailable desc = closing transport due to: connection error: desc = "error reading from server: EOF", received prior goaway: code: ENHANCE_YOUR_CALM, debug data: "too_many_pings" ```...

rpc error: code = Unavailable desc = closing transport due to: connection error: desc = "error reading from server: EOF", received prior goaway: code: ENHANCE_YOUR_CALM, debug data: "too_many_pings"root

https://github.com/Hyperledger-TWGC/tape/actions/runs/3305373542/jobs/5455449631#step:5:955 how many connections do you guys configured as targeting to server? as it passed in CI with ``` num_of_conn: 10 client_per_conn: 10 ```