Sam Yuan

Results 244 comments of Sam Yuan

> Maybe we could do exploration on other mature open source projects to learn some experience. i.e. those CNCF Graduated projects. If someone in our community has similar experience to...

+ @rootfs as https://www.bestpractices.dev/en/projects/7391's owner in loop.

it seems related with https://github.com/hyperledger/fabric-admin-sdk/pull/144

for api migration, maybe we need to double check if open telemetry supports all kinds of kepler metrics today. as I found Summaries type of metrics is marked as legacy...

are we done for this ticket? @rootfs

To be specific, how to set timeout makes me confusing as this newclient function invoking WithTimeout in current test case which is marked as Deprecated... for details at https://github.com/grpc/grpc-go/issues/7093

> Timeouts are not supported in `NewClient`. See https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#dialing-in-grpc for more info. > > If you need timeouts, feel free to keep using `Dial` or `DialContext`; they are not going...

https://github.com/Hyperledger-TWGC/tape/actions/runs/8551020475/job/23429132147?pr=384#step:5:25 ``` Error: SA1019: grpc.DialContext is deprecated: use NewClient instead. Will be supported throughout 1.x. (staticcheck) ```

> Timeouts are not supported in `NewClient`. See https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#dialing-in-grpc for more info. > > If you need timeouts, feel free to keep using `Dial` or `DialContext`; they are not going...

``` // The DialOptions returned by WithBlock, WithTimeout, and ``` .... ok I got the point. The current code comments guide me to I can use WithTimeout to return a...