Sam
Sure an extra method sound fine to me. Can you test that it works? If so make sure there is an expansion to the readme in the PR.
You would need to code that by hand, there is no automatic way of doing so.
In general you would handle custom segmentation by writing a custom collector, perhaps inherit off the sidekiq collector and adjust to taste?
Changing the default is not cleanly overridable, you would have to redefine the constant. Open to a PR here that makes changing defaults cleaner.
Sure I agree we should add metrics here for queue size. We do this in the Discourse Prometheus plugin. Happy for a PR that improves this.
I am fine with some examples being added to the readme, technically this is not complicated to add. On Tue, Oct 8, 2019 at 6:11 AM Jon Whitcraft wrote: >...
Yeah path is ultra weak, this is why our default rails middleware tries to send action and controller name per: https://github.com/discourse/prometheus_exporter/blob/master/lib/prometheus_exporter/middleware.rb#L42-L49 Do you have a access to action/controller name in...
A PR to improve our middleware is the way to go: route = nil if params action = params["action"] controller = params["controller"] else route = env["sinatra.route"] end
Do you have a bit more details about what you are collecting / how many metrics?
client should recover here, for sure, I consider this a bug.