Sam

Results 254 comments of Sam

Sounds reasonable to me ... @nateberkopec any concerns here, should we be providing instrumentation down to this fidelity?

I think you would need to extend the class to support that. What exactly are you trying to achieve?

I saw this, can you try to debug what is wrong with the json? what is the unexpected token?

Where is the client, is there a proxy between the client and server?

Can you repro this on local? If so a failing test case would be enormously useful.

What collectors are you running? On Fri, 4 Dec 2020 at 1:26 am, kubibektas wrote: > hi, > > we are using metrics collector as a centralized Kubernetes pod that...

I am open to have a PR that adds a trivial health check at so `/status` it can return an OK status 200 page.

I would say given it is not fully cross compatible this should be a switch (opt in) You can opt for `open metrics` format and then get `/metrics` that is...

I think it makes sense to add unconditionally On Thu, 17 Jun 2021 at 7:37 pm, z ***@***.***> wrote: > Other than e.g. the process instrumentation, the puma metrics do...

Sorry, I was way too short there. :pensive: I think it is fine to add hostname label for Puma unconditionally in a PR I am also not against adding support...