Sam
I would love to land this sooner vs later, anything we can do to help unblock you here @awesomerobot ?
very exciting change would love to see this happen!
oh I see, the test is not passing so the fix is not quite right :) looks like a more involved change.
this is fine, but we should have a test that confirms this is the case
The fix may be good but it is critical to have a test here, we can not merge as is.
not sure if I am happy with nesting this element and adding extra verboseness
This seems good, any reason not to merge it now?
A minimal thing we can do with the gem @eregon is have a special switch of "if truffle, do no harm" happy for a PR in that department if the...
One concern with only doing exec js is that we would miss out on the richness a MiniRacer type interface offers. ``` context = MiniRacer::Context.new context.attach("math.adder", proc{|a,b| a+b}) puts context.eval...
Yes we use MiniRacer directly in Discourse specifically due to the `attach` api. When cooking Markdown for example we can call into MRI Discourse to figure out if a user...