Sabrina Jewson
Sabrina Jewson
Well, it’s not technically const generics, just clever use of the existing type system. But yes, go ahead, I’d be honoured :D
From looking at the API, I don’t see the purpose in having that `'data` lifetime parameter — it doesn’t actually do anything, since it doesn’t feature in the public API...
Oh no, that's not what I meant 😅. Reqwest's `Client` is already internally ref-counted and cheaply clonable, so it's never needed to `Arc` it - I was proposing to internally...
> So you want to return an `Arc`-ed `Client` from building it? No, the idea is to do what Reqwest does: have `Client` internally just contain an `Arc`. `ClientInner` is...
I'm not sure about exposing `debug` - that's mostly a hack I used to print out information when the tests fail. I should switch to using `#[cfg(test)]` instead actually. I...
> Sorry for the holdup, I've been busy with other work lately. That's fine! :D > Maybe the two auth flows (client credentials vs. auth code) should be separate structs?...
> Btw, I think the error type does not really expose `reqwest::Error`, as the variant content is not public. All enum content is fully public in Rust - you can...
I like the `ClientBuilder` idea! I'll implement that. I don't want to make `credentials` an `Option` or an enum because for most use cases, it's not optional. I'm starting to...
Hmm — I can’t seem to reproduce, even with that exact setup. Does running `cargo check --manifest-path /tmp/inline-proc-crates/tauri-0.1-example/Cargo.toml` hang?
I tried with both the latest stable and latest nightly: `cargo 1.61.0 (a028ae4 2022-04-29)` and `cargo 1.63.0-nightly (8d42b0e87 2022-06-17)`.