Spencer Wilson

Results 185 comments of Spencer Wilson

> Hello, I turned on this option “OQS_USE_PTHREADS”when cmake. OQS_USE_PTHREADS cmake -GNinja.. -DBUILD_SHARED_LIBS=ON -DOQS_USE_PTHREADS=ON, it is still found that there will be competition between threads. How to eliminate contention between...

Short answer: [No, but it would be a nice feature to have.](https://github.com/open-quantum-safe/oqs-provider/issues/631)

> Do you have any guidelines? There are chances that I will have to deal with it I'm afraid not—I haven't actually worked on the provider much myself. Sorry that...

> OK - if we set a quite limited task to take pure PQ algorithms from OpenSSL and hybrid from oqs-provider - are there any show-stoppers except OIDs registrations? @praveksharma...

> I'm not getting this on Linux. Do I need to fix something? If you run `scripts/format_code.sh`, that should format the code in the same Docker container that we use...

Hi @AdijeShen, do you plan to continue with this PR?

> I've completed my revisions by removing the git submodule approach as requested. The current implementation uses static linking with liboqs.a instead of dynamic linking, which might require adjustments to...

Hi @AdijeShen, it looks like the whole repo has been reformatted to use CRLF line endings (\r\n). Could you please reformat to use only LF (\n)?

@johngray-dev As one of the primary users of the Java wrapper, could you please take a look at this PR? I'd like to understand the implications of moving from dynamic...

In the absence of any objections, merging once re-triggered CI passes. Thanks for the contribution @AdijeShen!