Spencer Wilson
Spencer Wilson
Correct the minor problems referenced in #55 and #56. Closes #55 Closes #56
The documentation for `reduce32` states that the output is in the range [-6283009, 6283007]. The range is actually [-6283009, 6283008], as evaluating `reduce32` at 2^{31} - 2^{22} - 1 will...
There are three unnecessary masks in the `polyt0_unpack` and `polyz_unpack` functions. These all occur when the last coefficient of a block of coefficients is being unpacked. There is no overflow...
After https://github.com/open-quantum-safe/liboqs/pull/1560 lands, the full KAT tests will be run on a weekly basis. Our weekly jobs currently (the KAT tests and the constant-time tests) only run on x86_64 /...
Preserving @baentsch's suggestion from #1618 so that it doesn't get buried after the merge: >> I don't know how to change the "2 approvals needed" rule to only apply to...
Currently, we handle `malloc` failures in common code by immediately exiting with a nonzero return code. It [could be a good idea](https://github.com/open-quantum-safe/liboqs/pull/1650#discussion_r1498209133) to give the program a chance to clear...
Enabling BIKE on x86 builds leads to [test failures](https://app.circleci.com/pipelines/github/open-quantum-safe/liboqs/3279/workflows/e8d367d9-2717-4105-a2f4-4bee216b0de3/jobs/26246), so we don't do it. However, the [upstream](https://github.com/awslabs/bike-kem/tree/master) documentation states that BIKE is supported for x86. It would be nice to...
https://github.com/open-quantum-safe/liboqs/pull/1585 updates HQC to the 2023-04-30 (currently latest) version, but it only includes a "clean" portable C implementation. An optimized AVX2 implementation is available from https://pqc-hqc.org, although it has a...
It would be nice to have documentation that links to the "sources of truth" for our KAT hashes. This would improve both ease of maintenance for developers and transparency for...
From the [Falcon reference implementation](https://falcon-sign.info/impl/falcon.h.html): > 127 * There are three formats for signatures: 128 * 129 * - COMPRESSED: this is the default format, which yields the shortest 130...