Sean Molenaar

Results 321 comments of Sean Molenaar

Or `brew services kill`, which should be pretty easy to do since we already have code for it.

Can we also check if the source exists and ensure the target directory does?

Changed it to a separate flag.

Only the actual signing command is left out for now since that depends on a specific macOS version for output checking. Otherwise I think it is good to go.

Okay, somehow my artifact filtering isn't working. I would have expected this line to output a list of only eligible artifacts. ```rb artifacts = cask.artifacts.select { |k| k.is_a?(Artifact::Pkg) || k.is_a?(Artifact::App)...

This looks cool. Just wanted to note that there are a couple of formula using `Utils.safe_popen_read({ "SHELL" => "bash" }, bin/"helm", "completion", "bash")` too. So you might want to check...

> It would be also good to add the options of generating the completions for individual shell (instead of generating for all shells). Isn't that what the `shells` argument will...

The brew domain didn't work for me, we'll have to see if the paid version allows custom domains but otherwise I think we're stuck on the current one.

> This would be a hard blocker on full adoption from me, I'm afraid 😭. Why would using an external domain for analytics be a blocker for you? Isn't the...

> We're self-hosting afterwards which means I want to set a higher standard for any future migrations. The current implementation isn't actually self-hosted. It's using InfluxDB Cloud (DBaaS).