brew
brew copied to clipboard
Homebrew
analytics: switch to InfluxDB for logging
- [x] Have you followed the guidelines in our Contributing document?
- [ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? Here's an example.
- [ ] Have you successfully run
brew stylewith your changes locally? - [ ] Have you successfully run
brew typecheckwith your changes locally? - [ ] Have you successfully run
brew testswith your changes locally?
Starting the work that was open for GSoC but is not part of GSoC
TODO:
- [ ] Subscribe to a paid InfluxDB Cloud account
- [ ] Reading analytics
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The brew domain didn't work for me, we'll have to see if the paid version allows custom domains but otherwise I think we're stuck on the current one.
The brew domain didn't work for me, we'll have to see if the paid version allows custom domains but otherwise I think we're stuck on the current one.
@SMillerDev This would be a hard blocker on full adoption from me, I'm afraid 😭. I can help when this PR is a bit further along, though.
A suggestion here would be to gate this functionality behind HOMEBREW_NEW_ANALYTICS_TESTING=1 (or something) and then this could be merged and tested before it's ready to be fully rolled out.
This would be a hard blocker on full adoption from me, I'm afraid 😭.
Why would using an external domain for analytics be a blocker for you? Isn't the same situation we have now?
A suggestion here would be to gate this functionality behind
HOMEBREW_NEW_ANALYTICS_TESTING=1(or something) and then this could be merged and tested before it's ready to be fully rolled out.
That's fine by me
Why would using an external domain for analytics be a blocker for you?
This is not just an external domain but one specific to a particular cloud provider and region.
Isn't the same situation we have now?
We're self-hosting afterwards which means I want to set a higher standard for any future migrations.
We're self-hosting afterwards which means I want to set a higher standard for any future migrations.
The current implementation isn't actually self-hosted. It's using InfluxDB Cloud (DBaaS).
The current implementation isn't actually self-hosted. It's using InfluxDB Cloud (DBaaS).
Cool. Let's get in touch with them and see what they can do for custom domains. What's the pricing like there?
@SMillerDev Thanks! May want to see if the "annual plan" is better and will need to watch our cardinality.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
@MikeMcQuaid actually forgot to update here. But we also can't do a vanity domain if we setup through Google Cloud. That would only be available if we self-host which I'd like to avoid. Most of the other TODO items are now done.
Should analytics report being Linuxbrew on Linux? I thought it was all Homebrew now?
Should analytics report being Linuxbrew on Linux? I thought it was all Homebrew now?
Yes, all Homebrew and a single analytics "bucket" with differing OS would be ideal.
@SMillerDev For now: ignore them. Are you ready to merge as-is? If so: I can do it manually.