Sean Molenaar

Results 493 comments of Sean Molenaar

Any way we can update the git crate in rust? https://github.com/rust-lang/git2-rs/blob/master/CHANGELOG.md#0190---2024-06-13 should work.

> Agree, that might help with the migration stuff. As far as I can tell there isn't much to migrate. Just that one left.

https://github.com/Homebrew/formula-patches/tree/remove-unused-patches exists now. But I guess it also needs to create a PR?

I'd be slightly uncomfortable pushing directly to master

> The base branch requires all commits to be signed. That's unfortunate, see https://github.com/Homebrew/formula-patches/pull/908

🥳 https://github.com/Homebrew/formula-patches/pull/909

I'm not sure what to do with this. @Bo98 do you want to rewrite this in ruby and call it with `brew ruby`?

The generated PR has some comments from Bo, but I'm not sure what to do with them or _if_ we should do something with them.

Rebased this, let's try again.

That should be fixed upstream. Can you make an issue or a pull request for it?