qwt: add path to qwt.framework/Headers to Cflags in the .pc
The original .pc file only sets Cflags to be Cflags: -I${includedir} -F${libdir}. Since Qwt installs the actual, non-Qt-style-proxy headers to qwt.framework/Headers, projects relying on pkgconfig fail to find those. This change appends the path to the framework's Headers as well.
- [x] Have you followed the guidelines for contributing?
- [x] Have you ensured that your commits follow the commit style guide?
- [x] Have you checked that there aren't other open pull requests for the same formula update/change?
- [x] Have you built your formula locally with
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting? - [x] Is your test running fine
brew test <formula>, where<formula>is the name of the formula you're submitting? - [x] Does your build pass
brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?
That should be fixed upstream. Can you make an issue or a pull request for it?
@SMillerDev I tried that, but I don't know qmake's pkgconfig automagic well enough to understand what'd be the right fix there. After trying to figure that out for an hour or so, I figured it's more efficient (cost/benefit-wise) to just patch it here.
I can open an issue on their bugtracker as well in the meanwhile, but given that AFAIK most qwt devs mostly use linux, I doubt it'll be acted on soon.
Homebrew only accepts patches if upstream know about it, to avoid situations like https://www.debian.org/security/2008/dsa-1571
But if you have an issue reference you can add as a comment that's good enough.
@SMillerDev sorry for the delay. Filed at https://sourceforge.net/p/qwt/bugs/382/ .
Thanks @0xd34df00d ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
@SMillerDev sorry for bumping this old issue, but I just noticed this got closed without actually merging. Is there anything I can/need to do to push it over the finish line?
Thanks!