homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

qwt: add path to qwt.framework/Headers to Cflags in the .pc

Open 0xd34df00d opened this issue 8 months ago • 5 comments

The original .pc file only sets Cflags to be Cflags: -I${includedir} -F${libdir}. Since Qwt installs the actual, non-Qt-style-proxy headers to qwt.framework/Headers, projects relying on pkgconfig fail to find those. This change appends the path to the framework's Headers as well.


  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

0xd34df00d avatar Jun 07 '25 17:06 0xd34df00d

That should be fixed upstream. Can you make an issue or a pull request for it?

SMillerDev avatar Jun 07 '25 17:06 SMillerDev

@SMillerDev I tried that, but I don't know qmake's pkgconfig automagic well enough to understand what'd be the right fix there. After trying to figure that out for an hour or so, I figured it's more efficient (cost/benefit-wise) to just patch it here.

I can open an issue on their bugtracker as well in the meanwhile, but given that AFAIK most qwt devs mostly use linux, I doubt it'll be acted on soon.

0xd34df00d avatar Jun 07 '25 18:06 0xd34df00d

Homebrew only accepts patches if upstream know about it, to avoid situations like https://www.debian.org/security/2008/dsa-1571

But if you have an issue reference you can add as a comment that's good enough.

SMillerDev avatar Jun 08 '25 10:06 SMillerDev

@SMillerDev sorry for the delay. Filed at https://sourceforge.net/p/qwt/bugs/382/ .

0xd34df00d avatar Jun 17 '25 20:06 0xd34df00d

Thanks @0xd34df00d ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

SMillerDev avatar Jun 18 '25 17:06 SMillerDev

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jul 19 '25 00:07 github-actions[bot]

@SMillerDev sorry for bumping this old issue, but I just noticed this got closed without actually merging. Is there anything I can/need to do to push it over the finish line?

Thanks!

0xd34df00d avatar Nov 23 '25 05:11 0xd34df00d