Samuel Macias - OSI comments

Results 17 comments of


                                            Samuel Macias - OSI

[ADD] pos_order_zip

@max3903 @dreispt @AmmarOfficewalaSerpentCS

[16.0][MIG] hr_employee_number_generate_and_search

@max3903 @pedrobaeza

[16.0][MIG] hr_employee_number_generate_and_search

@max3903 This works now

17.0 [MIG] fieldservice_sale

This PR requires #1150 to be merged first so the test can pass after a rebase

[MIG][16.0] hr_employee_id: Migrated module.

@max3903 @pedrobaeza I have a question. We would like to modify this module in order to use the existing field employee_number instead of the new field identification_id. To make this...

[MIG][16.0] hr_employee_id: Migrated module.

> I think that should be another module, not this one. The functionality would be the exact same, just making use of an existing field instead of adding a new...

[16.0][ADD] purchase_order_line_filter_product_by_department

@max3903 I have tested this. It works as expected

[16.0][MIG] web_tree_dynamic_colored_field

@AmmarOfficewalaSerpentCS Tests are still failing. Please fix these ASAP cc: @max3903

[17.0][ADD] mrp_bom_compute_sales_price

> Hello @SMaciasOSI and thanks for this work If i understand well the code, your module permits to quickly apply sale price to a product thanks to the sum of...

[17.0][ADD] mrp_bom_compute_sales_price

> Yep ok ! Two modules for two very differents usages ! (don't hesitate to review mine ;-)) It's seems to be quite a draft as you are fixing stuffs...