hr icon indicating copy to clipboard operation
hr copied to clipboard

[MIG][16.0] hr_employee_id: Migrated module.

Open Chirag-OSI opened this issue 1 year ago • 9 comments

Chirag-OSI avatar Apr 02 '24 13:04 Chirag-OSI

/ocabot migration hr_employee_id

pedrobaeza avatar Apr 02 '24 13:04 pedrobaeza

@max3903 @pedrobaeza I have a question. We would like to modify this module in order to use the existing field employee_number instead of the new field identification_id. To make this change, should I wait for this migration PR to be merged first and then do a new PR with the mod, or can I add the adjustments to this PR?

SMaciasOSI avatar Apr 02 '24 14:04 SMaciasOSI

I think that should be another module, not this one.

pedrobaeza avatar Apr 02 '24 14:04 pedrobaeza

I think that should be another module, not this one.

The functionality would be the exact same, just making use of an existing field instead of adding a new one. Both fields serve virtually the same purpose

SMaciasOSI avatar Apr 02 '24 14:04 SMaciasOSI

But you may be using the other for another purpose. Is it a new field? Is it hidden by any reason?

pedrobaeza avatar Apr 02 '24 14:04 pedrobaeza

@max3903 @pedrobaeza I have a question. We would like to modify this module in order to use the existing field employee_number instead of the new field identification_id. To make this change, should I wait for this migration PR to be merged first and then do a new PR with the mod, or can I add the adjustments to this PR?

I do agree, since identification field is listed in Nationality info group, mean it's original purpose is for nationality identification number, not company id number.

image

unique4 avatar Jun 11 '24 02:06 unique4

Hi @pedrobaeza

It seems the build is stuck, is it possible to restart it ?

maisim avatar Jun 19 '24 07:06 maisim

I can't do that. The contributor should do a push on their branch to relaunch it.

pedrobaeza avatar Jun 19 '24 07:06 pedrobaeza

It seems the build is stuck, is it possible to restart it ?

I can't do that. The contributor should do a push on their branch to relaunch it.

:hand: @Chirag-OSI

maisim avatar Jun 19 '24 07:06 maisim

Superseded by #1373, as there's no answer.

pedrobaeza avatar Aug 16 '24 07:08 pedrobaeza