Ryan Zimmerman comments

Results 239 comments of


Ryan Zimmerman

Copying a directory to a path that already has a directory with that name does not throw an error even when options are set correctly.

:man_facepalming: I feel silly; I did know that, but I somehow forgot about it when I replied.

Better error message for ensureSymlink if the current existing link is broken

ping @manidlou

Line breaks in filenames cause infinite loops in mkdirs & mkdirsSync

Huh, these weird cases. What's the result of calling `fs.mkdir` with a newline in the filename? (when the parent directories exist)

Line breaks in filenames cause infinite loops in mkdirs & mkdirsSync

No wonder it crashes. `ENOENT` is also the error code we get when the parent doesn't exist, so we respond by trying to create the parent. That causes an infinite...

Line breaks in filenames cause infinite loops in mkdirs & mkdirsSync

@manidlou That's the ugly part. AFAIK, on Windows, newlines aren't allowed. However, they may be allowed on some Linux systems, not sure. We could either error out on a newline,...

Line breaks in filenames cause infinite loops in mkdirs & mkdirsSync

@wrager I'm leaning in that direction as well. If only Windoze would throw a sensible error for invalid characters instead of `ENOENT`... :grimacing:

Line breaks in filenames cause infinite loops in mkdirs & mkdirsSync

@manidlou Yeah, we probably should. That's gonna be messy, though. I didn't think about that.

Line breaks in filenames cause infinite loops in mkdirs & mkdirsSync

Well, hopefully https://github.com/nodejs/node/pull/21875 solves this for newer Node versions.

Inconsistency between readJson and readJsonSync when file does not exist

@jprichardson This inconsistency is actually documented: https://github.com/jprichardson/node-jsonfile#readfilefilename-options-callback Do you know why you built it this way?

Inconsistency between readJson and readJsonSync when file does not exist

So it seems `throws` was built for sync, because it's a pain to stop sync errors. It was added to async because someone didn't want to have to check if...